Skip to content

[circle-mlir/infra] Create debian rules and related files#15467

Merged
seanshpark merged 2 commits intoSamsung:masterfrom
shs-park:circle-mlir/debian-onnx2circle-rules
May 27, 2025
Merged

[circle-mlir/infra] Create debian rules and related files#15467
seanshpark merged 2 commits intoSamsung:masterfrom
shs-park:circle-mlir/debian-onnx2circle-rules

Conversation

@shs-park
Copy link
Copy Markdown
Contributor

This adds the rules and its related files for the onnx2circle Debian package installation.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park shs.park@samsung.com

This adds the rules and its related files for the `onnx2circle`
Debian package installation.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
@shs-park shs-park requested a review from a team May 27, 2025 09:39
@shs-park shs-park self-assigned this May 27, 2025
@shs-park
Copy link
Copy Markdown
Contributor Author

for issue #15424
from draft #15440

@shs-park shs-park added the PR/ready for review It is ready to review. Please review it. label May 27, 2025
@@ -0,0 +1,2 @@
# bin
usr/share/circletools/bin/onnx2circle usr/bin/onnx2circle
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we don't need this for current user scenario.
onnx2circle is conversion tool called from one-import-onnx and it would be better not to expose this tool in command line.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, then let's remove this link.

ONE-DCO-1.0-Signed-off-by: Seungho Henry Park <shs.park@samsung.com>
Co-authored-by: SaeHie Park <saehie.park@gmail.com>
@shs-park shs-park requested review from a team and seanshpark May 27, 2025 10:28
Copy link
Copy Markdown
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 3bf2a64 into Samsung:master May 27, 2025
7 checks passed
@shs-park shs-park deleted the circle-mlir/debian-onnx2circle-rules branch May 28, 2025 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

PR/ready for review It is ready to review. Please review it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants